-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 10 Upgrade #5168
Laravel 10 Upgrade #5168
Conversation
Accessing Faker properties was deprecated in Faker 1.14.
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them and merged your true customizations - where ENV variables may not be used.
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
…r to solve vulnerabilities
This reverts commit cbb8798.
This reverts commit 82f3a25.
Laravel 10.x Shift
QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a smoke test of the main functionalities
SonarQube Quality Gate Reliability Rating on New Code (is worse than A) See analysis details on SonarQube Fix issues before they fail your Quality Gate with SonarLint in your IDE. |
QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net |
3 similar comments
QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net |
QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net |
QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net |
Issue & Reproduction Steps
See https://processmaker.atlassian.net/browse/FOUR-9714
Laravel upgrade from 8 to 9 to 10
Solution
How to Test
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-7194
Packages
https://github.com/ProcessMaker/connector-docusign/pull/36
https://github.com/ProcessMaker/connector-send-email/pull/263
https://github.com/ProcessMaker/docker-executor-node-ssr/pull/9
https://github.com/ProcessMaker/package-actions-by-email/pull/118
https://github.com/ProcessMaker/package-collections/pull/360
https://github.com/ProcessMaker/package-data-sources/pull/314
https://github.com/ProcessMaker/package-decision-engine/pull/53
https://github.com/ProcessMaker/package-pm-blocks/pull/84
https://github.com/ProcessMaker/package-savedsearch/pull/378
https://github.com/ProcessMaker/package-sentry/pull/16
https://github.com/ProcessMaker/package-translations/pull/60
https://github.com/ProcessMaker/package-versions/pull/69
https://github.com/ProcessMaker/package-vocabularies/pull/82
https://github.com/ProcessMaker/package-webentry/pull/213
ProcessMaker/pmql#35
Code Review Checklist
ci:next
ci:connector-send-email:feature/FOUR-9714
ci:docker-executor-node-ssr:feature/FOUR-9714
ci:package-webentry:feature/FOUR-9714
ci:package-savedsearch:feature/FOUR-9714
ci:package-data-sources:feature/FOUR-9714
ci:package-sentry:feature/FOUR-9714
ci:package-translations:feature/FOUR-9714
ci:pmql:feature/FOUR-9714
ci:package-pm-blocks:feature/FOUR-9714
ci:package-actions-by-email:feature/FOUR-9714
ci:package-collections:feature/FOUR-9714
ci:connector-docusign:feature/FOUR-9714
ci:package-decision-engine:feature/FOUR-9714
ci:package-vocabularies:feature/FOUR-9714
ci:package-versions:feature/FOUR-9714
ci:deploy
..